Feature scenarios - #24
Open
jnnr wants to merge 6 commits into
Open
Conversation
for more information, see https://pre-commit.ci
irm-codebase
approved these changes
Aug 30, 2026
irm-codebase
left a comment
irm-codebase
left a comment
Contributor
There was a problem hiding this comment.
Very nice! Only a small comment on the schema settings.
As always, @sjpfenninger is the end-all-be-all when it comes to changes in this module.
But to me it looks good!
| description: "Schema for user-provided configuration files." | ||
| type: object | ||
| additionalProperties: false | ||
| properties: |
Contributor
There was a problem hiding this comment.
Please keep additionalProperties: false at the lowermost level of the schema too.
Otherwise users would be able to fill this section with irrelevant configurations that would never be caught.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes in this pull request
scenariosas a config property andscenarioas a wildcard, which allows to vary technology assumptions. This parallels thescenariowildcard in module_geo_boundaries.Reviewer checklist
pipdependencies in the module's environment files (workflow/envs/).pathvars(e.g.,<results>) in their inputs and outputs.pre-commit.citests pass.INTERFACE.yamlmentions all relevantpathvarsandwildcards.README.mddescribes how to use the module and has the necessary citations.